Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump plugwise to v0.37.2 #115989

Merged
merged 10 commits into from
Apr 23, 2024
Merged

Bump plugwise to v0.37.2 #115989

merged 10 commits into from
Apr 23, 2024

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Apr 22, 2024

Proposed change

Update the plugwise backend to v0.37.2: https://github.com/plugwise/python-plugwise/releases/tag/v0.37.2

plugwise/python-plugwise@v0.37.1...v0.37.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @CoMPaTech, @frenck, mind taking a look at this pull request as it has been labeled with an integration (plugwise) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of plugwise can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign plugwise Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bouwew bouwew changed the title Bump plugwise to v0.37.3 Bump plugwise to v0.37.2 Apr 22, 2024
@bouwew bouwew marked this pull request as ready for review April 22, 2024 18:46
@bouwew bouwew requested a review from frenck as a code owner April 22, 2024 18:46
@bouwew bouwew force-pushed the pw_0_37_3 branch 2 times, most recently from c66acde to f5d8b92 Compare April 23, 2024 10:58
@bouwew
Copy link
Contributor Author

bouwew commented Apr 23, 2024

Test-fails are unrelated.

@frenck
Copy link
Member

frenck commented Apr 23, 2024

Can you rebase the PR? Since this PR is coming from an org, I cannot do that for you.

@CoMPaTech
Copy link
Contributor

Can you rebase the PR? Since this PR is coming from an org, I cannot do that for you.

Trying to do that using the GUI 🤞

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks both! 👍

../Frenck

@frenck frenck merged commit 2c7a1dd into home-assistant:dev Apr 23, 2024
38 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants