Add service to 17track to get packages #116067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joostlek
reviewed
Apr 24, 2024
| get_packages: | ||
| fields: | ||
| package_state: | ||
| example: "In Transit,Delivered" |
There was a problem hiding this comment.
I think we can make this a select selector since we already know all possible values
joostlek
requested changes
Apr 24, 2024
| return_response=SupportsResponse.ONLY, | ||
| ) | ||
|
|
||
| assert len(service_response["packages"]) == 2 |
There was a problem hiding this comment.
Cool. Never knew about snapshot
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
change to select selector add snapshot test
use strings for the selector
…u-17track-service
joostlek
approved these changes
Apr 24, 2024
joostlek
changed the title
fix test
This was referenced Apr 24, 2024
| DOMAIN, | ||
| SERVICE_GET_PACKAGES, | ||
| get_packages, | ||
| supports_response=SupportsResponse.ONLY, |
There was a problem hiding this comment.
I'm missing a service validation schema.
| """Get packages from 17Track.""" | ||
| config_entry_id = call.data[ATTR_CONFIG_ENTRY_ID] | ||
| package_states = call.data.get(ATTR_PACKAGE_STATE, []) | ||
| seventeen_coordinator: SeventeenTrackCoordinator = hass.data[DOMAIN][ |
There was a problem hiding this comment.
We need to handle a missing or not loaded config entry before accessing hass.data. Raise ServiceValidationError.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add service to 17track
Type of change
Additional information
Checklist
ruff format homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: