Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move thread safety check in async_register/async_remove #116077

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 24, 2024

Proposed change

Move the thread safety check in the async_register and async_remove path to be sooner so it catches the problem before the service is being registered.

Previously it would catch it when async_fire was called which was confusing to the dev because it would complain about async_fire and not async_register or async_remove.

RuntimeError: Detected that custom integration 'scaletest' calls async_register from a thread at custom_components/scaletest/__init__.py, line 18: hass.services.async_register(DOMAIN, "not_safe", lambda x : None). Please report it to the author of the 'scaletest' custom integration.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Move the thread safety check in the async_register
and async_remove path to be sooner so it catches
the problem before the service is being registered.

Previously it would catch it when async_fire was
called which was confusing to the dev because it
would complain about async_fire and not async_register
or async_remove.
@bdraco bdraco marked this pull request as ready for review April 24, 2024 05:26
@bdraco bdraco requested a review from a team as a code owner April 24, 2024 05:26
@frenck frenck merged commit e0b58c3 into dev Apr 24, 2024
38 checks passed
@frenck frenck deleted the move_register branch April 24, 2024 08:41
@bdraco
Copy link
Member Author

bdraco commented Apr 24, 2024

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants