Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small speed up to async_track_event #116083

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Small speed up to async_track_event #116083

merged 1 commit into from
Apr 24, 2024

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 24, 2024

TODO: redo profile to estimate speed up

Proposed change

This is one of the most called functions at startup so small optimizations matter here. This is a ~32.4% speed up

  • use a defaultdict to avoid some calls and simplify the code
  • avoid functools partial lookup each call

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

This is one of the most called functions at startup so
small optimizations matter here

- use a defaultdict to avoid some calls and simplify the code
- avoid functools partial lookup each call
@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels Apr 24, 2024
@bdraco bdraco marked this pull request as ready for review April 24, 2024 07:52
@bdraco bdraco requested a review from a team as a code owner April 24, 2024 07:52
@frenck frenck merged commit b520efb into dev Apr 24, 2024
38 checks passed
@frenck frenck deleted the async_track_event branch April 24, 2024 07:57
@bdraco
Copy link
Member Author

bdraco commented Apr 24, 2024

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants