New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate the dynamic package sensors in seventeentrack #116102
base: dev
Are you sure you want to change the base?
Deprecate the dynamic package sensors in seventeentrack #116102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the beta for 2024.5 has now been cut, the earliest deprecation start will be 2024.6.
Also is it possible to raise a deprecation warning when the deprecated functions are used?
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
@joostlek what did we decide on here? |
I think there are 2 things we should keep in mind after I did some reviewing of the code
I think it would also be nice to have some example templates in the documentation to help people get started with this new way of fetching the extra data. I can ask some people if they are able to help out with this. |
add more information when retrieving packages from service call
update deprecation comment
Breaking changes
...
Proposed change
Add deprecation comments for the dynamic package sensors
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: