Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra sensor to the Jewish Calendar integration #116734

Merged
merged 7 commits into from
Jun 6, 2024

Conversation

gedaliahknizhnik
Copy link
Contributor

@gedaliahknizhnik gedaliahknizhnik commented May 3, 2024

Proposed change

Issue 116322 identifies a feature that would be helpful in the Jewish calendar. There are different opinions regarding the time for Tseit HaKochavim (stars coming out), which in the current version is based on the "first_stars" time. There are cases where consistently using the more stringent "three_stars" time is helpful, so this PR adds an additional sensor that provides that time.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #116322
  • This PR is related to issue: #116322
  • Link to documentation pull request: 32598

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link

@home-assistant home-assistant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @gedaliahknizhnik

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

home-assistant bot commented May 3, 2024

Hey there @tsvi, mind taking a look at this pull request as it has been labeled with an integration (jewish_calendar) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of jewish_calendar can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign jewish_calendar Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@MartinHjelmare MartinHjelmare changed the title Added extra sensor to the Jewish Calendar integration Add extra sensor to the Jewish Calendar integration May 4, 2024
@gedaliahknizhnik gedaliahknizhnik marked this pull request as ready for review May 5, 2024 20:59
@gedaliahknizhnik gedaliahknizhnik marked this pull request as draft May 7, 2024 20:56
@gedaliahknizhnik gedaliahknizhnik marked this pull request as ready for review May 7, 2024 20:57
@gedaliahknizhnik
Copy link
Contributor Author

@tsvi have you had a chance to take a look at this?

@tsvi
Copy link
Contributor

tsvi commented May 20, 2024

Looks good to me, but unfortunately we cannot add new features until #84464 is merged if I understand correctly. There's a request not to add new features until integrations have been moved to config flow.

@tsvi
Copy link
Contributor

tsvi commented May 20, 2024

In any case, you need to sign the CLA.

@gedaliahknizhnik
Copy link
Contributor Author

@tsvi ok. I can wait, just figured the approval would be good. I did sign the CLA, but it hasn't updated... If I try to sign it again it says there are no pending requests.

@balloob balloob merged commit 696a079 into home-assistant:dev Jun 6, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants