-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra sensor to the Jewish Calendar integration #116734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
Hey there @tsvi, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@tsvi have you had a chance to take a look at this? |
Looks good to me, but unfortunately we cannot add new features until #84464 is merged if I understand correctly. There's a request not to add new features until integrations have been moved to config flow. |
In any case, you need to sign the CLA. |
@tsvi ok. I can wait, just figured the approval would be good. I did sign the CLA, but it hasn't updated... If I try to sign it again it says there are no pending requests. |
Proposed change
Issue 116322 identifies a feature that would be helpful in the Jewish calendar. There are different opinions regarding the time for Tseit HaKochavim (stars coming out), which in the current version is based on the "first_stars" time. There are cases where consistently using the more stringent "three_stars" time is helpful, so this PR adds an additional sensor that provides that time.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: