Add sensors for Unifi latency

[kimdv]

Breaking change

Proposed change

This PR aims to add Unifi latency to HA.

By adding this we have the ability to automate if it increase etc or other trigger what people can think of.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @Kane610, mind taking a look at this pull request as it has been labeled with an integration (unifi) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of unifi can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign unifi Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[kimdv]

If this accepted and almost done I will add documentation.

[Kane610]

Nice addition, some small changes needed based on mypy

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[Kane610]

I've published aiounifi v78 Kane610/aiounifi@v77...v78

[kimdv]

I've published aiounifi v78 Kane610/aiounifi@v77...v78

Should I update the dependency in this PR or does it need to be. Sperrte PR?

[Kane610]

I've published aiounifi v78 Kane610/aiounifi@v77...v78

Should I update the dependency in this PR or does it need to be. Sperrte PR?

You can do it in this one

[Kane610]

It's way too much duplication here so need to figure out how it can be boiled down to one instance

[kimdv]

It's way too much duplication here so need to figure out how it can be boiled down to one instance

Any suggestions ?

Tried to look at bit into it.
Couldn't find a way

[Kane610]

You can deduplicate all instances of wan/wan2 with partial

[Kane610]

We could simplify the PR initially and only take one value from Wan as a start anf then look at improving it.

[Kane610]

Maybe some extra thing can be added to be the entity description that can be used to deduce that each entity is based on more data

[kimdv]

We could simplify the PR initially and only take one value from Wan as a start anf then look at improving it.

Will start with WAN.
Having a bit hard to see how it can be done. Python is not my primary language 😅

Maybe some extra thing can be added to be the entity description that can be used to deduce that each entity is based on more data

Yes we have the same "problem" with storage.
As here it's possible to attach multiple storage devices to the Unifi.
I even think the new Dream Machine Pro Max have two disk bays.

[kimdv]

Maybe some extra thing can be added to be the entity description that can be used to deduce that each entity is based on more data

If you can guide me a bit, I'm willing to try to implement this

[Kane610]

Having a bit hard to see how it can be done. Python is not my primary language 😅

[Kane610]

So if you start with WAN and decide on just one latency source you can hard code it all.

So I have a few alternate paths forward, they are not concrete but only notions yet.

1 Change a bit more how its exposed in the library, not sure how
2 Add an extra property on UnifiEntityDescription which can provide one more layer of data source, which it can iterate over, not sure how pretty this would be
3 Do a method that would generate additional list items for ENTITY_DESCRIPTIONS, this is closer to what you have done now but still less duplication

I think both 2 and 3 would benefit other sensors like TX/RX sensors as well

[Kane610]

Thinking more about it maybe 3 is the way to go for now

[kimdv]

@Kane610 I just did a rebase. I was more than 400 commits behind.

I use a Mac with VSCode and dev containers.
Do you know why I now get this error when I try > Run Task -> Install requirements

 *  Executing task: uv pip install -r requirements_all.txt 

error: error sending request for url (https://pypi.org/simple/aiobotocore/)
  Caused by: client error (Connect)
  Caused by: invalid peer certificate: BadSignature

 *  The terminal process "/usr/bin/zsh '-c', 'uv pip install -r requirements_all.txt'" terminated with exit code: 2. 
 *  Press any key to close the terminal. 

[Kane610]

Try starting with a./script/setup