Custom forecast

[kamiyo]

Proposed change

A WIP to allow comment for allowing extra attributes back into the weather forecast, this time as a dict on extra_attributes attribute. Right now, the weather template limits the attributes forecasts can return, but many services return useful and interesting data (for example, it is possible from NWS to get chance of thunderstorm, wet bulb temperature, etc.). Another attribute name could be used instead of extra_attributes. I thought about extended, but in the context of a forecast, that sounds like an extended timescale. Maybe extra_attr.

I am also unsure about the reason for the strict attribute validation in forecasts.

Integrations that already returned extra attributes prior to the current version of the template will be able to reincorporate those attributes under the extra attribute (so will have to be rewritten, but those broke anyways with the current template validation). This was passionately debated here: #114799

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Weather template validation is too strict and/or NWS integration returns bad forecasts #114799
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• I have followed the perfect PR recommendations
• The code has been formatted using Ruff (ruff format homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (weather) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of weather can trigger bot actions by commenting:

• @home-assistant close Closes the pull request.
• @home-assistant rename Awesome new title Renames the pull request.
• @home-assistant reopen Reopen the pull request.
• @home-assistant unassign weather Removes the current integration label and assignees on the pull request, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

[bdraco]

This PR changes an Core entity component model by changing the behavior of our weather entity component.

New features/changes to our models must first be architecturally proposed by creating a discussion in our architecture repository, and approved by the core team.

Please create an proposal first.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.