-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZHA XZG firmware discovery #116828
Add ZHA XZG firmware discovery #116828
Conversation
Add XZG Firmware ZeroConf
Add XZG Firmware ZeroConf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @dmulcahey, @Adminiuga, @puddly, @TheJulianJES, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
@xyzroe suggest also submit PR to next branch of zha documentation for the home-assistant.io repository: https://www.home-assistant.io/integrations/zha/#discovery-via-usb-or-zeroconf https://github.com/home-assistant/home-assistant.io/blob/next/source/_integrations/zha.markdown |
Is this firmware in use by any devices yet? If not, let's hold off on merging this PR because I would like to steer future TCP coordinators to use a general |
Some users have already updated their devices to this firmware. Everyone would like to use it already. |
Any news? Users want to use XZG firmware with ZHA right now :) |
@xyzroe Thanks for the PR! |
Ok. I'll make it. |
Proposed change
Add XZG Firmware ZeroConf to ZHA.
Tested locally
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: