Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid exceptions when Gemini responses are blocked #116847

Merged
merged 7 commits into from
May 6, 2024

Conversation

tronikos
Copy link
Contributor

@tronikos tronikos commented May 5, 2024

Breaking change

Proposed change

For offensive queries the library sometimes throws BlockedPromptException or StopCandidateException which are already caught but other times it just returns empty parts which causes a ValueError when converted to text. Avoid that by responding with: "Sorry, I had a problem talking to Google Generative AI. Likely blocked"

(Ignore the dependency upgrade, that is being done in #116845)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@allenporter allenporter merged commit 5c4afe5 into home-assistant:dev May 6, 2024
24 checks passed
@tronikos tronikos deleted the googleai_block branch May 6, 2024 09:47
@github-actions github-actions bot locked and limited conversation to collaborators May 7, 2024
@joostlek joostlek added this to the 2024.5.4 milestone May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

list index out of range on some of the calls to Google Generative AI Conversation
4 participants