-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust title of integration sensor #116954
Conversation
This matches "derivate sensor" as well as min/max/media sensors.
Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Have looked several time at this, The issue now is that it does not match any of the documentation or popular community posts |
I wish each helper could have more detailed description in that menu. But this name has been an eyesore for quite some time. Maybe docs do need an update indeed. I dont think we should block based on community posts. Its not hard to deduce which one it is. |
Added a docs update for the same change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Discussed, this quickly to see what others think, but all agree.
We do need to adjust the manifest as well to reflect this same change.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
might rename the directory too |
We can't change the domain (which is what the directory reflects). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @elupus 👍
../Frenck
This matches "derivate sensor" as well as min/max/media sensors.
Proposed change
Adjust the name of the integration helper flow to match how derivative and others are named. The fact that we are doing riemann integration is an implementation detail.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: