Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust title of integration sensor #116954

Merged
merged 2 commits into from
May 25, 2024
Merged

Conversation

elupus
Copy link
Contributor

@elupus elupus commented May 6, 2024

This matches "derivate sensor" as well as min/max/media sensors.

Proposed change

Adjust the name of the integration helper flow to match how derivative and others are named. The fact that we are doing riemann integration is an implementation detail.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

This matches "derivate sensor" as well as min/max/media sensors.
@home-assistant
Copy link

home-assistant bot commented May 6, 2024

Hey there @dgomes, mind taking a look at this pull request as it has been labeled with an integration (integration) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of integration can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign integration Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@dgomes
Copy link
Contributor

dgomes commented May 6, 2024

Have looked several time at this,

The issue now is that it does not match any of the documentation or popular community posts

@elupus
Copy link
Contributor Author

elupus commented May 6, 2024

I wish each helper could have more detailed description in that menu. But this name has been an eyesore for quite some time.

Maybe docs do need an update indeed. I dont think we should block based on community posts. Its not hard to deduce which one it is.

@elupus
Copy link
Contributor Author

elupus commented May 8, 2024

Added a docs update for the same change.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed, this quickly to see what others think, but all agree.

We do need to adjust the manifest as well to reflect this same change.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 18, 2024 11:15
@dgomes
Copy link
Contributor

dgomes commented May 18, 2024

might rename the directory too

@frenck
Copy link
Member

frenck commented May 18, 2024

might rename the directory too

We can't change the domain (which is what the directory reflects).

@elupus elupus marked this pull request as ready for review May 24, 2024 19:06
@home-assistant home-assistant bot requested a review from frenck May 24, 2024 19:06
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @elupus 👍

../Frenck

@frenck frenck merged commit 943799f into home-assistant:dev May 25, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants