-
-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nws blocking startup #117094
Merged
bdraco
merged 6 commits into
home-assistant:dev
from
MatthewFlamm:nws-dont-block-startup
May 8, 2024
Merged
Fix nws blocking startup #117094
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ef2f816
avoid retry in setup
MatthewFlamm e48c642
more typing
MatthewFlamm e150fdc
Use async naming convention
MatthewFlamm dc6e9a8
more naming convention
MatthewFlamm 4b4f423
use partial
MatthewFlamm f6f743d
revert changes for observation
MatthewFlamm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the future: Sometimes its faster to do an
asyncio.gather
here (withcreate_eager_task
)It will depend on if more connections is slower or faster with the remote server
example
core/homeassistant/bootstrap.py
Line 430 in 189c07d
If the server doesn't like more connections at once it can be slower though so it has to be tested to see the result
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I had to guess, NWS won't like multiple connections, but I can look into testing.