-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move vallox coordinator to separate module #117503
Conversation
Hey there @andre-richter, @slovdahl, @viiru-, @yozik04, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
class ValloxDataUpdateCoordinator(DataUpdateCoordinator[MetricData]): | ||
"""The DataUpdateCoordinator for Vallox.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why don't we move the coordinator + super init to here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it a slightly bigger refactor, but I think it's ok.
* Move vallox coordinator to separate module * Move logic into coordinator class * Adjust
Proposed change
SSIA, linked to #108174
I also took the opportunity to move the update method into the coordinator
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: