-
-
Notifications
You must be signed in to change notification settings - Fork 28.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add snapshot tests to elmax #117637
Add snapshot tests to elmax #117637
Conversation
Hey there @albertogeniola, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Not perfect coverage yet, but it's a start:
|
'changed_by': None, | ||
'code_arm_required': False, | ||
'code_format': <CodeFormat.NUMBER: 'number'>, | ||
'friendly_name': 'Direct Panel https://1.1.1.1:443/api/v2 AREA 1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General remark, can we get better initial naming for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO this is out of scope of this PR.
The names seem to be coming from the library:
core/homeassistant/components/elmax/common.py
Lines 75 to 77 in 081bf1c
def get_name_by_user(self, username: str) -> str: | |
"""Return the panel name.""" | |
return f"Direct Panel {self.hash}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh definetly, but I still wanted to mention it
Can you delete all snapshots and generate them again? |
Proposed change
SSIA, as preliminary work for #117425
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: