Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up async_render_with_possible_json_value #118080

Merged
merged 1 commit into from
May 25, 2024
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 25, 2024

Proposed change

While contextlib.suppress is a bit more compact, it is much slower than try/except since python3.11+ has near zero cost try which is much cheaper than creating a context manager, entering, and exiting it. In this case we will almost never raise an exception here and this function is called 1000s (10000+ on larger mqtt setups) of times at startup.

In this case it was nearly 1/3+ of the run time of this function.

before
before_suppress

after
after_remove_suppress

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

While contextlib.suppress is a bit more compact, it is much
slower than try/except since python3.11+ has near zero cost
try which is much cheaper than creating a context manager,
entering, and existing it. In this case we will almost
never raise an exception here and this function is called
1000s of times at startup.
@bdraco bdraco marked this pull request as ready for review May 25, 2024 03:43
@bdraco bdraco requested a review from a team as a code owner May 25, 2024 03:43
@bdraco
Copy link
Member Author

bdraco commented May 25, 2024

thanks

tests/components/plaato/* test failures are unrelated to this PR and are because the snapshot has stored yesterday's date

@bdraco bdraco merged commit 5cb3bc1 into dev May 25, 2024
33 of 34 checks passed
@bdraco bdraco deleted the template_context_mg branch May 25, 2024 03:43
@github-actions github-actions bot locked and limited conversation to collaborators May 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants