-
-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add number input for apsystems #118825
Add number input for apsystems #118825
Conversation
Hey there @SonnenladenGmbH, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I'd really like to get this PR into the next release, as many users will probably complain about this option being unavailable and the APsystems integration seems to be landing with HA 2024.7 |
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
…dant and single use variables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM... but @joostlek should confirm
Thanks! Would you mind taking a look at the docs as well if you should have the time? |
Hey there @SonnenladenGmbH, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I don't want to annoy anyone, but the questions where the functions went get kinda annoying and I'd like to continue with the next PRs |
Breaking change
Proposed change
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: