Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number input for apsystems #118825

Merged
merged 5 commits into from
Jun 17, 2024

Conversation

mawoka-myblock
Copy link
Contributor

@mawoka-myblock mawoka-myblock commented Jun 4, 2024

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jun 4, 2024

Hey there @SonnenladenGmbH, mind taking a look at this pull request as it has been labeled with an integration (apsystems) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of apsystems can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign apsystems Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mawoka-myblock
Copy link
Contributor Author

I'd really like to get this PR into the next release, as many users will probably complain about this option being unavailable and the APsystems integration seems to be landing with HA 2024.7

homeassistant/components/apsystems/number.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/number.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/number.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/apsystems/number.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft June 5, 2024 06:54
@home-assistant
Copy link

home-assistant bot commented Jun 5, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@mawoka-myblock mawoka-myblock marked this pull request as ready for review June 5, 2024 12:50
@home-assistant home-assistant bot requested a review from epenet June 5, 2024 12:50
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM... but @joostlek should confirm

@mawoka-myblock
Copy link
Contributor Author

Thanks! Would you mind taking a look at the docs as well if you should have the time?

@home-assistant
Copy link

home-assistant bot commented Jun 8, 2024

Hey there @SonnenladenGmbH, mind taking a look at this pull request as it has been labeled with an integration (apsystems) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of apsystems can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign apsystems Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@mawoka-myblock
Copy link
Contributor Author

I don't want to annoy anyone, but the questions where the functions went get kinda annoying and I'd like to continue with the next PRs

@joostlek joostlek merged commit 496338f into home-assistant:dev Jun 17, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner integration: apsystems new-feature Quality Scale: No score smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants