Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate attributes when entity information available in Group sensor #119021

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

gjohansson-ST
Copy link
Member

Proposed change

Change that attributes device class, state class and unit of measurement is only calculated once all entitiy can provide details (state or entity registry).

Fixes if group starts before integration of consumed entities or other related things when entity data is not available during group sensor starts.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@gjohansson-ST gjohansson-ST added this to the 2024.6.1 milestone Jun 6, 2024
@gjohansson-ST gjohansson-ST requested a review from a team as a code owner June 6, 2024 22:50
home-assistant[bot]

This comment was marked as outdated.

@home-assistant
Copy link

home-assistant bot commented Jun 6, 2024

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant
Copy link

home-assistant bot commented Jun 6, 2024

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (group) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of group can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign group Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@gjohansson-ST gjohansson-ST force-pushed the group-sensor-calc-attr-when-entity-data-available branch from bf29d26 to e0946e8 Compare June 6, 2024 22:52
@gjohansson-ST gjohansson-ST marked this pull request as ready for review June 6, 2024 22:52
homeassistant/components/group/sensor.py Show resolved Hide resolved
homeassistant/components/group/sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft June 7, 2024 07:59
@catsmanac
Copy link
Contributor

As noted in 118695 resolves the issue for the Group sums on utility_meter and integration but nested groups (Group sum of other Group Sum) still have the issue if one of the source groups get loaded after the group summing it.

@frenck frenck modified the milestones: 2024.6.1, 2024.6.2 Jun 7, 2024
@gjohansson-ST gjohansson-ST marked this pull request as ready for review June 9, 2024 16:26
@home-assistant home-assistant bot requested a review from edenhaus June 9, 2024 16:26
@catsmanac
Copy link
Contributor

Running updated code still has the issue for group sum summing other group sum. No UOM and history does not show as value trend.

afbeelding

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gjohansson-ST 👍

@edenhaus
Copy link
Contributor

Merging it now as it solves the issues for most use cases

@edenhaus edenhaus merged commit fc915dc into dev Jun 11, 2024
38 checks passed
@edenhaus edenhaus deleted the group-sensor-calc-attr-when-entity-data-available branch June 11, 2024 07:26
@frenck frenck mentioned this pull request Jun 11, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sensor group with sum does not consistently add unit
4 participants