-
-
Notifications
You must be signed in to change notification settings - Fork 29.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calculate attributes when entity information available in Group sensor #119021
Calculate attributes when entity information available in Group sensor #119021
Conversation
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
bf29d26
to
e0946e8
Compare
As noted in 118695 resolves the issue for the Group sums on utility_meter and integration but nested groups (Group sum of other Group Sum) still have the issue if one of the source groups get loaded after the group summing it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gjohansson-ST 👍
Merging it now as it solves the issues for most use cases |
Proposed change
Change that attributes device class, state class and unit of measurement is only calculated once all entitiy can provide details (state or entity registry).
Fixes if group starts before integration of consumed entities or other related things when entity data is not available during group sensor starts.
Type of change
Additional information
Checklist
ruff format homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: