Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump env-canada to 0.6.3 #120035

Merged
merged 4 commits into from
Jun 21, 2024
Merged

Bump env-canada to 0.6.3 #120035

merged 4 commits into from
Jun 21, 2024

Conversation

gwww
Copy link
Contributor

@gwww gwww commented Jun 20, 2024

Proposed change

Bump env_canada lib to 0.6.3 to resolve blocking calls in the main thread.

michaeldavie/env_canada@v0.6.2...v0.6.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @michaeldavie, mind taking a look at this pull request as it has been labeled with an integration (environment_canada) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of environment_canada can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign environment_canada Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Jun 20, 2024
@MartinHjelmare MartinHjelmare changed the title Bump env_canada lib to 0.7.0. Remove precip_yesterday sensor removed by Environment Canada Bump env-canada to 0.7.0 Jun 20, 2024
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gwww

@bdraco
Copy link
Member

bdraco commented Jun 20, 2024

It would be better to do the breaking change in a separate PR

@gwww
Copy link
Contributor Author

gwww commented Jun 20, 2024

@michaeldavie my PR could be 0.6.3 and then 0.7.0 could be added separately.

@michaeldavie
Copy link
Contributor

Good idea, I've created a v0.6.3 release with just your changes.

@gwww
Copy link
Contributor Author

gwww commented Jun 21, 2024

This PR has backed off from 0.7.0 of env_canada lib to version 0.6.3 (new created to remove the breaking change). Another PR with the breaking change will be submitted.

@bdraco
Copy link
Member

bdraco commented Jun 21, 2024

Is this one now safe to tag for a patch release?

@bdraco bdraco changed the title Bump env-canada to 0.7.0 Bump env-canada to 0.6.3 Jun 21, 2024
@bdraco bdraco added this to the 2024.6.4 milestone Jun 21, 2024
@gwww
Copy link
Contributor Author

gwww commented Jun 21, 2024

Thanks! Safe for patch release! There with be another bump PR for the breaking change to be slotted in next monthly release.

@bdraco
Copy link
Member

bdraco commented Jun 21, 2024

Thanks. Kicked the CI...hopefully its happy this time

Copy link
Contributor

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gwww 👍

@edenhaus edenhaus merged commit 3b6189a into home-assistant:dev Jun 21, 2024
34 of 35 checks passed
frenck pushed a commit that referenced this pull request Jun 21, 2024
Co-authored-by: J. Nick Koston <nick@koston.org>
@frenck frenck mentioned this pull request Jun 21, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants