Refactor Alexa Smart Home API #12016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having an object per interface will make it easier to support properties. Ideally, properties are reported in context in all responses. However current implementation reports them only in response to a ReportState request. This seems to work sufficiently. As long as the device is opened in the Alexa app, Amazon will poll the device state every few seconds with a ReportState request.
balloob
approved these changes
Jan 28, 2018
balloob
reviewed
Jan 28, 2018
| 'supported': self.properties_supported(), | ||
| 'proactivelyReported': self.properties_proactively_reported(), | ||
| }, | ||
| # XXX this is incorrect, but the tests assert it |
There was a problem hiding this comment.
If it's incorrect, let's remove it. Shouldn't hurt our interaction with Alexa?
There was a problem hiding this comment.
I see that you have fixed this in #11973 but I don't want the dev branch to be in a broken state, so let's include the fix in this PR.
There was a problem hiding this comment.
It was broken before -- I just didn't notice. I can re-arrange.
balloob
approved these changes
Jan 28, 2018
Merged
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
No functionality changes here. Just a refactor to lay the groundwork for #11973 .
Having an object per interface will make it easier to support
properties.
Ideally, properties are reported in context in all responses. However
current implementation reports them only in response to a ReportState
request. This seems to work sufficiently. As long as the device is
opened in the Alexa app, Amazon will poll the device state every few
seconds with a ReportState request.
Checklist:
toxrun successfully. Your PR cannot be merged unless tests pass