Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DataUpdateCoordinator to pyLoad integration #120237

Merged
merged 14 commits into from
Jun 24, 2024

Conversation

tr4nt0r
Copy link
Contributor

@tr4nt0r tr4nt0r commented Jun 23, 2024

Proposed change

Adds a DataUpdateCoordinator

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

homeassistant/components/pyload/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/pyload/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/pyload/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/pyload/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/pyload/sensor.py Outdated Show resolved Hide resolved
@tr4nt0r tr4nt0r marked this pull request as ready for review June 23, 2024 15:20
@tr4nt0r tr4nt0r requested a review from joostlek June 23, 2024 15:21
@tr4nt0r tr4nt0r requested a review from joostlek June 23, 2024 15:56
@tr4nt0r tr4nt0r marked this pull request as draft June 23, 2024 16:28
@tr4nt0r tr4nt0r marked this pull request as ready for review June 23, 2024 17:24
@tr4nt0r tr4nt0r requested a review from joostlek June 23, 2024 22:36
@joostlek joostlek merged commit 237f20d into home-assistant:dev Jun 24, 2024
25 checks passed
@tr4nt0r tr4nt0r deleted the pyload_coordinator branch June 24, 2024 11:03
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants