miflora - fix for exception handling bug #12149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristianKuehnel
requested review from
andrey-git and
Danielhiversen
as code owners
|
Why not use the pypi version? |
|
The version 0.2.0 of miflora on pypi does not yet include the bug fixes. And I do not have the permissions to create a new release. |
|
Have you proposed a new release in the miflora library? |
|
Then we should wait for a new release |
|
Linking requirements to GitHub is not allowed anymore. We will have to wait for a release. We're working on writing this down in an official policy |
|
Miflora version 0.3 is out. I'll update this PR on the weekend... |
Merged
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
With the release of miflora 0.2 there were two bugs in the exception handling. These are fixed in a development branch of miflora now. This PR pulls in this development branch and also handles the new exception type.
Once a the new release of miflora is out, we can switch back to the official releases: basnijholt/miflora#83
Related issue (if applicable): fixes #11815 #9048
Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully. Your PR cannot be merged unless tests passREQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass