Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Xiaomi MiIO Remote: Lazy discover disabled #12710

Merged
merged 3 commits into from Mar 5, 2018
Merged

Xiaomi MiIO Remote: Lazy discover disabled #12710

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a4d6cdd
Lazy discovery disabled: The Chuang Mi IR Remote Controller wants to …
syssi Feb 26, 2018
1da373b
Use a unique data key per domain.
syssi Feb 27, 2018
05e64a5
Named argument used and comment added.
syssi Feb 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 10 additions & 6 deletions homeassistant/components/remote/xiaomi_miio.py
View file
Open in desktop
Expand Up @@ -26,7 +26,7 @@
_LOGGER = logging.getLogger(__name__)

SERVICE_LEARN = 'xiaomi_miio_learn_command'
PLATFORM = 'xiaomi_miio'
DATA_KEY = 'remote.xiaomi_miio'

CONF_SLOT = 'slot'
CONF_COMMANDS = 'commands'
Expand Down Expand Up @@ -70,7 +70,11 @@ def async_setup_platform(hass, config, async_add_devices, discovery_info=None):

# Create handler
_LOGGER.info("Initializing with host %s (token %s...)", host, token[:5])
device = ChuangmiIr(host, token)

# The Chuang Mi IR Remote Controller wants to be re-discovered every
# 5 minutes. As long as polling is disabled the device should be
# re-discovered (lazy_discover=False) in front of every command.
device = ChuangmiIr(host, token, lazy_discover=False)

# Check that we can communicate with device.
try:
Expand All @@ -79,8 +83,8 @@ def async_setup_platform(hass, config, async_add_devices, discovery_info=None):
_LOGGER.error("Token not accepted by device : %s", ex)
return

if PLATFORM not in hass.data:
hass.data[PLATFORM] = {}
if DATA_KEY not in hass.data:
hass.data[DATA_KEY] = {}

friendly_name = config.get(CONF_NAME, "xiaomi_miio_" +
host.replace('.', '_'))
Expand All @@ -93,7 +97,7 @@ def async_setup_platform(hass, config, async_add_devices, discovery_info=None):
friendly_name, device, slot, timeout,
hidden, config.get(CONF_COMMANDS))

hass.data[PLATFORM][host] = xiaomi_miio_remote
hass.data[DATA_KEY][host] = xiaomi_miio_remote

async_add_devices([xiaomi_miio_remote])

Expand All @@ -106,7 +110,7 @@ def async_service_handler(service):

entity_id = service.data.get(ATTR_ENTITY_ID)
entity = None
for remote in hass.data[PLATFORM].values():
for remote in hass.data[DATA_KEY].values():
if remote.entity_id == entity_id:
entity = remote

Expand Down