Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rounding of temperature reading #13018

Merged
merged 1 commit into from
Mar 9, 2018
Merged

Remove rounding of temperature reading #13018

merged 1 commit into from
Mar 9, 2018

Conversation

hthiery
Copy link
Contributor

@hthiery hthiery commented Mar 9, 2018

With homeassistant 0.65.0 the filter sensor is introduced. Now there
is a common way to filter the peaks comming from the readings.

Checklist:

  • The code change is tested and works locally.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass
  • Tests have been added to verify that the new code works.

With homeassistant 0.65.0 the filter sensor is introduced. Now there
is a common way to filter the peaks comming from the readings.

Signed-off-by: Heiko Thiery <heiko.thiery@gmail.com>
@arsaboo
Copy link
Contributor

arsaboo commented Mar 9, 2018

The filter sensor is not solving the temperature rounding problem. We probably still need the rounding so that it appears properly in the frontend.

@hthiery
Copy link
Contributor Author

hthiery commented Mar 9, 2018

I just used the rounding here to minimize the hight jitter around the themperature readings. E.g. it was often observed that the reading value changed from one to another value and back every state update. I hoped to fix this with the filter sensor.

My workaround with round was just to reduce this behavior, but it was still present on the 0.5 to 0.6 step and at 0.9 to 1.0... so this workaround reduced the resolution from 0.1 steps to 0.5 steps what is a limitaion.

@hthiery hthiery changed the title remove rounding of temperature reading Remove rounding of temperature reading Mar 9, 2018
@balloob balloob merged commit 556901e into home-assistant:dev Mar 9, 2018
@balloob
Copy link
Member

balloob commented Mar 9, 2018

That's good that we have removed this. We shouldn't have merged this to begin with. It's important that integration of devices show the raw API data. It's indeed up to 2nd order things, like the filter sensor, to smooth it out.

@balloob balloob mentioned this pull request Mar 30, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants