Changed to async/await #13246
Merged
Changed to async/await #13246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Mar 15, 2018
| @@ -392,8 +383,8 @@ def async_update_status(self): | |||
| self._group_name = group_name | |||
| # the sleep is needed to make sure that the | |||
| # devices is synced | |||
| yield from asyncio.sleep(1, loop=self._hass.loop) | |||
| yield from self.async_trigger_sync_on_all() | |||
| time.sleep(1) | |||
There was a problem hiding this comment.
Never ever use time.sleep. It blocks the event loop or executor thread (depending on context). Keep using asyncio.sleep because you're inside an async context and that won't block.
There was a problem hiding this comment.
Ah, I was confused :)
I've changed it back now
| @asyncio.coroutine | ||
| def _start_poll_command(self): | ||
|
|
||
| async def _start_poll_command(self): |
| @@ -254,16 +249,16 @@ def force_update_sync_status( | |||
| on_updated_cb() | |||
| return True | |||
|
|
|||
| @asyncio.coroutine | |||
| def _start_poll_command(self): | |||
|
|
|||
|
|
||
| @asyncio.coroutine | ||
| def force_update_sync_status( | ||
|
|
|
|
||
| @asyncio.coroutine | ||
| def async_setup_platform(hass, config, async_add_devices, discovery_info=None): | ||
| async def async_setup_platform(hass, config, async_add_devices, |
pvizeli
approved these changes
Mar 17, 2018
Merged
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: