Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't add falsy items to list (merge_packages) #13536

Merged
merged 1 commit into from
Mar 30, 2018

Conversation

kellerza
Copy link
Member

Description:

merge_pakages added falsy items to list (i.e. empty OrderedDict() from load_yaml added to automation list)

Related issue (if applicable): fixes #13412

FIXED Example entry for configuration.yaml (if applicable):

homeassistant:
  packages:
    empty_auto:
      automation: !include empty.yaml

automation:
  - alias: "Some valid automation"

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@kellerza kellerza requested a review from a team as a code owner March 29, 2018 23:26
@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels Mar 29, 2018
@balloob balloob added this to the 0.66 milestone Mar 30, 2018
@balloob balloob merged commit a6b63b6 into home-assistant:dev Mar 30, 2018
balloob pushed a commit that referenced this pull request Mar 30, 2018
@kellerza kellerza deleted the empty_merge branch March 30, 2018 00:24
@balloob balloob mentioned this pull request Mar 30, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automations file can't be empty with packages
4 participants