Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix mysensors sensor type lookup #13574

Merged
merged 1 commit into from Mar 31, 2018
Merged

Fix mysensors sensor type lookup #13574

merged 1 commit into from Mar 31, 2018

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Mar 31, 2018 •
edited

Description:

  • Always return a safe default.

Related issue (if applicable):
fixes #13573

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@MartinHjelmare
Fix mysensors sensor type lookup
097243f 
* Always return a safe default.
@MartinHjelmare MartinHjelmare added this to the 0.66.1 milestone Mar 31, 2018
fabaff
fabaff approved these changes Mar 31, 2018
View reviewed changes
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 72fb646 into home-assistant:dev Mar 31, 2018
@MartinHjelmare MartinHjelmare deleted the fix-unit-lookup branch March 31, 2018 13:40
balloob pushed a commit that referenced this pull request Apr 1, 2018
@MartinHjelmare @balloob
Fix mysensors sensor type lookup (#13574)
52d2139 
* Always return a safe default.
@balloob balloob mentioned this pull request Apr 1, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fabaff fabaff fabaff approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed integration: mysensors small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.66.1
Development

Successfully merging this pull request may close these issues.

0.66 Mysensors sensor entities broken
4 participants
@MartinHjelmare @fabaff @balloobbot @homeassistant