Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support binary_sensor and device_tracker in HomeKit. #13735

Merged
merged 7 commits into from
Apr 9, 2018
Merged

Support binary_sensor and device_tracker in HomeKit. #13735

merged 7 commits into from
Apr 9, 2018

Commits on Apr 9, 2018

  1. Support binary_sensor and device_tracker for HomeKit

    Yonsm authored and Yonsm committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    c4c052a View commit details
    Browse the repository at this point in the history

  2. Add test for get_accessory and binary sensor 

    Passed:
 tox -e py36 -- tests/components/homekit/test_type_sensors.py -x
tox -e py36 -- tests/components/homekit/test_get_accessories.py -x
    Yonsm authored and Yonsm committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    46154a1 View commit details
    Browse the repository at this point in the history

  3. Wrap line to 79 chars

    Yonsm authored and Yonsm committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    63066d2 View commit details
    Browse the repository at this point in the history

  4. Test service.display_name and char_detected.display_name 

    1. Passed: tox -e py36 -- tests/components/homekit/test_type_sensors.py
-x
2. And remove ‘# Ensure state.attributes’ comment
    Yonsm authored and Yonsm committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    5389eac View commit details
    Browse the repository at this point in the history

  5. Fix continuation line under-indented for visual indent

    Yonsm authored and Yonsm committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    d403288 View commit details
    Browse the repository at this point in the history

  6. Refine testcase for type_sensors.py with more coverage 

    PASSED: tox -e py36 -- tests/components/homekit/test_type_sensors.py
PASSED: script/lint (in my submit)
    Yonsm authored and Yonsm committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    3883373 View commit details
    Browse the repository at this point in the history

  7. Split test to improve speed

    @cdce8p
    cdce8p committed Apr 9, 2018
    Configuration menu
    Copy the full SHA
    25088c5 View commit details
    Browse the repository at this point in the history