Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backend tweaks to make authorization work #14339

Merged
merged 7 commits into from May 10, 2018
Merged

Backend tweaks to make authorization work #14339

merged 7 commits into from May 10, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented May 7, 2018 •
edited

Description:

Have the frontend component ensure it has a client to allow users to login and expose it on the index.html.

Backend to home-assistant/frontend#1147

Example entry for configuration.yaml (if applicable):

homeassistant:
  auth_providers:
    - type: insecure_example
      users:
        - username: test-user
          password: test-pass

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner May 7, 2018 22:11
houndci-bot
houndci-bot reviewed May 7, 2018
View reviewed changes
homeassistant/components/websocket_api.py Outdated
@@ -8,6 +8,7 @@
from concurrent import futures
from contextlib import suppress
from functools import partial
import hmac
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'hmac' imported but unused

homeassistant/components/auth/__init__.py Outdated
"""Create a new login flow."""
redirect_uri = request.query.get('redirect_uri')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local variable 'redirect_uri' is assigned to but never used

@balloob balloob changed the title WIP: Backend tweaks to make authorization work Backend tweaks to make authorization work May 8, 2018
@pvizeli pvizeli merged commit 5ec7fc7 into dev May 10, 2018
@pvizeli pvizeli deleted the auth-authorize branch May 10, 2018 08:38
@pvizeli
Copy link
Member

pvizeli commented May 10, 2018

Let us collect experience with this and maybe optimize it later.

@balloob balloob mentioned this pull request May 28, 2018
Merged
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@balloob
Backend tweaks to make authorization work (home-assistant#14339)
1a74d74 
* Backend tweaks to make authorization work

* Lint

* Add test

* Validate redirect uris

* Fix tests

* Fix tests

* Lint
@home-assistant home-assistant locked and limited conversation to collaborators Sep 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@pvizeli pvizeli pvizeli approved these changes

Assignees
No one assigned
Labels
cla-signed core integration: api integration: auth integration: frontend integration: http integration: websocket_api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balloob @pvizeli @houndci-bot @homeassistant