Add homematicip cloud climate platform #14388
Conversation
worm-ee
changed the title
|
@sander76 now I have implemented the climate group as well. Have a look.... |
| class HomematicipHeatingGroup(HomematicipGenericDevice, ClimateDevice): | ||
| """Representation of a MomematicIP heating group.""" | ||
|
|
||
| def __init__(self, hass, home, device): |
| @property | ||
| def icon(self): | ||
| """Return the icon.""" | ||
| return 'mdi:nest-thermostat' |
There was a problem hiding this comment.
The nest icon is deprecated. Use mdi:thermostat.
| def current_operation(self): | ||
| """Return current operation (auto, manual, boost, vacation).""" | ||
| if self._device.boostMode: | ||
| return STATE_BOOST |
There was a problem hiding this comment.
Only states present in the climate base component are allowed. If you want to add a new state, it needs to pass consensus in an issue in the architecture repo first.
There was a problem hiding this comment.
@MartinHjelmare STATE_BOOST is also used in homematic climate platform. This is quite useful for users as this turns the heating on for a few minutes and changes then back to automatic mode. The feature is named in all Homematic(IP) boost mode.
There was a problem hiding this comment.
That doesn't change how we should do things. Changes to entity model needs to go through review in the architecture repo:
https://developers.home-assistant.io/docs/en/entity_index.html#changing-the-entity-model
There's already an issue about climate model:
home-assistant/architecture#22
| modes = [] | ||
| for profile in self._device.profiles: | ||
| if profile.name != '' and profile.enabled and profile.visible: | ||
| modes.append(profile.name) |
There was a problem hiding this comment.
@MartinHjelmare Then I need your advise: The Homematic(IP) devices have in automatic mode dedicated time and temperature profiles. Users would definitely like to switch between them. With this implementation I add the profile names (the user can name them as the like in the app) and use them like automatic states. How should I implement this feature?
Thanks Mattias
There was a problem hiding this comment.
I'd wait with implementing any operation modes that are not already listed in the climate component, for this PR. When it's been decided how the future of the climate component will be, it'll be easier to know how to handle these things.
| else: | ||
| await self._device.set_boost(False) | ||
| index = 0 | ||
| for profile in self._device.profiles: |
There was a problem hiding this comment.
Use enumerate to get the index of the profile.
|
|
||
| async def async_set_operation_mode(self, operation_mode): | ||
| """Set operation mode.""" | ||
| if operation_mode == 'Boost': |
worm-ee
changed the title
| def current_operation(self): | ||
| """Return current operation ie. automatic or manual.""" | ||
| return HMIP_STATE_TO_HA.get(self._device.controlMode) | ||
|
|
worm-ee
changed the title
* Add support for climatic devices * Update requirements_all * Change icon to mdi:thermostat * Update of homematicip-rest-api lib version * Remove all mode or state relevant things - will come later * Add current_operation again to see proper status * Remove STATE_PERFORMANCE import * Remove trailing whitespace * Update requirements file
ghost
removed
the
Description:
Pull request in home-assistant.github.io with documentation (if applicable):
home-assistant/home-assistant.io#5396
Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.