Use None as initial state in zha component #14389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
platform: sensor.zha
small-pr
| @@ -102,8 +102,8 @@ def unit_of_measurement(self): | |||
| @property | |||
| def state(self): | |||
| """Return the state of the entity.""" | |||
| if self._state == 'unknown': | |||
| return 'unknown' | |||
| if self._state == STATE_UNKNOWN: | |||
There was a problem hiding this comment.
We shouldn't use STATE_UNKNOWN at all in the platforms or components. Probably change this in the zha component, that seems to set the initial state. Initial state should be None.
MartinHjelmare
changed the title
MartinHjelmare
changed the title
Merged
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
According to @MartinHjelmare comment in #14361, return
Noneif state is unknown.Checklist: