-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bmw_connected_drive - provide position of HA installation - WIP #14464
bmw_connected_drive - provide position of HA installation - WIP #14464
Conversation
This solves issues with some vehicles as discussed in bimmerconnected/bimmer_connected#62
@@ -84,6 +87,12 @@ def setup_account(account_config: dict, hass, name: str) \ | |||
region = account_config[CONF_REGION] | |||
_LOGGER.debug('Adding new account %s', name) | |||
cd_account = BMWConnectedDriveAccount(username, password, region, name) | |||
if account_config[CONF_SEND_LOCATION]: | |||
_LOGGER.debug('Account %s is configured to upload the location of your ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (80 > 79 characters)
@@ -14,19 +14,22 @@ | |||
from homeassistant.helpers.event import track_utc_time_change | |||
import homeassistant.helpers.config_validation as cv | |||
|
|||
REQUIREMENTS = ['bimmer_connected==0.5.0'] | |||
# TODO: replace with new release when available | |||
REQUIREMENTS = ['https://github.com/m1n3rva/bimmer_connected/archive/master.zip#bimmer_connected==0.5.1'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (105 > 79 characters)
Hi @ChristianKuehnel
If I set
so maybe |
@ChristianKuehnel : I had to replace |
Going to close this. You can open it again if a new bimmer release has happened. |
Description:
This solves issues with some vehicles as discussed in
bimmerconnected/bimmer_connected#62
These vehicles require the client to upload it's current position to the server. Only if this position is within some range (e.g. 2km) of the vehicle, you will get data from the vehicle.
This feature is configurable, so you only need to disclose the location if your car requires it. See example below
bimmer_connected
library, once it was tested successfully.Related issue (if applicable): fixes bimmerconnected/bimmer_connected#62
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml
(if applicable):send_location: True
Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: