-
-
Notifications
You must be signed in to change notification settings - Fork 28.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Songpal sound mode support #14718
Conversation
add sound mode support using new denonavr library functions
This is usefull because the sound_mode_raw shows more information than only the sound_mode.
try: | ||
soundfields = await self.dev.get_soundfield() | ||
self._soundmodes = {x.value:x.title for x in soundfields.candidate} | ||
self._active_soundmode = self._soundmodes[soundfields.currentValue] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (83 > 79 characters)
|
||
try: | ||
soundfields = await self.dev.get_soundfield() | ||
self._soundmodes = {x.value:x.title for x in soundfields.candidate} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing whitespace after ':'
line too long (83 > 79 characters)
@@ -171,6 +172,15 @@ def available(self): | |||
_LOGGER.debug("Got ins: %s", inputs) | |||
self._sources = inputs | |||
|
|||
|
|||
try: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too many blank lines (2)
"""Return device specific state attributes.""" | ||
attributes = {} | ||
if self._sound_mode_raw is not None and self._sound_mode_support\ | ||
and self._power == 'ON': |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
continuation line over-indented for visual indent
Description:
Implement sound mode support for songpal
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: