Change radiotherm state attributes

[cpw]

Description:

The two device_state_attributes don't return the current actual state (fan on/off, heat/cool), but rather the mode of the fan or thermostat (generally auto). As such this change makes the actual current state visible to the system, so you can do stuff when the fan turns on, for example. I suspect this is just a bug, but maybe it was intended NOT to be able to see the actual fan state?

Breaking change:
The radiotherm fan and mode state attributes were updated to reflect the real-time fan and mode states of the thermostat, rather than the overall selected state (automatic, mostly). The mode attributes still contain the selected modes (fan on/auto, heat/cool/auto).

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

• The code change is tested and works locally.
• Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

• New dependencies have been added to the REQUIREMENTS variable (example).
• New dependencies are only imported inside functions that use them (example).
• New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
• New files were added to .coveragerc.

If the code does not interact with devices:

• Tests have been added to verify that the new code works.

[homeassistant]

Hi @cpw,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

[awarecan]

@cpw you should merge to dev branch, not master.

[cpw]

Sorry, the PR was automatically generated by github. I think I fixed it, by retargetting what github generated?

[MartinHjelmare]

Please add a paragraph in the description about the breaking change, for the release notes.

[cpw]

This is a breaking change?

The two state attributes were just duplicating the "selected mode" (fan on all the time or automatic and heat/cool/auto selected) previously.

This "fix" actually reports the real state of the thermostat instead: so fan on when it's running (off when not) and cool/heat/idle when it's cooling/heating or idle.
It's a breaking change if you expected the mode data in the state attributes I suppose, but it wasn't very useful as the mode attributes already told you that. /shrug.