Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade holidays to 0.9.6 #15831

Merged
merged 1 commit into from Aug 7, 2018
Merged

Upgrade holidays to 0.9.6 #15831

merged 1 commit into from Aug 7, 2018

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Aug 4, 2018

Description:

Changes: https://github.com/dr-prodigy/python-holidays/blob/master/CHANGES

Example entry for configuration.yaml (if applicable):

binary_sensor:
  - platform: workday
    country: CH

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.

@ghost ghost assigned fabaff Aug 4, 2018
@ghost ghost added the in progress label Aug 4, 2018

# homeassistant.components.frontend
home-assistant-frontend==20180803.0
home-assistant-frontend==20180804.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rebase to resolve this.

@fabaff
Copy link
Member Author

fabaff commented Aug 6, 2018

@fabaff fabaff merged commit 51c3098 into dev Aug 7, 2018
@ghost ghost removed the in progress label Aug 7, 2018
@fabaff fabaff deleted the upgrade-holidays branch August 7, 2018 07:12
@balloob balloob mentioned this pull request Aug 17, 2018
@ptdalen
Copy link

ptdalen commented Aug 22, 2018

Component failed upon upgrade to 76.2 from 75.3

received the following errors

2018-08-21 19:34:11 ERROR (MainThread) [homeassistant.components.binary_sensor] Error while setting up platform workday
Traceback (most recent call last):
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/helpers/entity_platform.py", line 129, in _async_setup_platform
    SLOW_SETUP_MAX_WAIT, loop=hass.loop)
  File "/usr/lib/python3.6/asyncio/tasks.py", line 358, in wait_for
    return fut.result()
  File "/usr/lib/python3.6/concurrent/futures/thread.py", line 56, in run
    result = self.fn(*self.args, **self.kwargs)
  File "/srv/homeassistant/lib/python3.6/site-packages/homeassistant/components/binary_sensor/workday.py", line 73, in setup_platform
    obj_holidays = getattr(holidays, country)(years=year)
AttributeError: module 'holidays' has no attribute 'US'

Reverted to previous version of component and it worked for me.

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Aug 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants