Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Tahoma Lighting Receiver on/off io #15925

Merged
merged 4 commits into from
Sep 2, 2018
Merged

Add support for Tahoma Lighting Receiver on/off io #15925

merged 4 commits into from
Sep 2, 2018

Conversation

fucm
Copy link
Contributor

@fucm fucm commented Aug 10, 2018

Description:

Add support for Tahoma Lighting Receiver on/off io

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

If user exposed functionality or configuration variables are added/changed:

  • No additional documentation required

If the code communicates with devices, web services, or third-party tools:

  • No new dependencies.
  • No new files.

If the code does not interact with devices:

  • Does interact with devices

@ghost ghost added the in progress label Aug 10, 2018
MartinHjelmare
MartinHjelmare reviewed Aug 12, 2018
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Fix the lint issue and we can merge.

homeassistant/components/switch/tahoma.py Outdated
_LOGGER.debug("Turn off: %s", self._name)
if self.tahoma_device.type == 'rts:GarageDoor4TRTSComponent':
return
else:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This else can be removed since there's a return statement above.

@fucm
Copy link
Contributor Author

fucm commented Aug 12, 2018

Else removed, but where is the lint issue? tox and pylint did not show anything.

@MartinHjelmare
Copy link
Member

Else removed, but where is the lint issue? tox and pylint did not show anything.

Travis pylint job failed:
https://travis-ci.org/home-assistant/home-assistant/jobs/414602722#L565

MartinHjelmare
MartinHjelmare approved these changes Aug 12, 2018
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare
Copy link
Member

Can be merged when build passes.

@Danielhiversen Danielhiversen merged commit a5cff98 into home-assistant:dev Sep 2, 2018
@ghost ghost removed the in progress label Sep 2, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@fucm
Add support for Tahoma Lighting Receiver on/off io (home-assistant#15925
06e74e5 
)

* Add support for Tahoma light switch

* Clean up attributes and add available method

* Remove else statement
@balloob balloob mentioned this pull request Sep 17, 2018
Merged
@fucm fucm deleted the tahoma-io-switch branch September 23, 2018 18:30
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
@ghost ghost removed the platform: switch.tahoma label Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
almost-done cla-signed integration: tahoma
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fucm @MartinHjelmare @Danielhiversen @homeassistant