Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT embedded broker has to set its own password #15929

Merged
merged 1 commit into from Aug 13, 2018

Conversation

awarecan
Copy link
Contributor

@awarecan awarecan commented Aug 11, 2018

Description:

In order to remove http.api_password in future, we need decouple api_password and other components. MQTT embedded broker has to set its own password.

Breaking changes
If user configured http.api_password and used default embedded MQTT broker configuraiton, mqtt component will fail to setup to prompt this change. Error message is

Starting from 0.76, embedded MQTT broker doesn't use api_password as default password any more. Please set password configuration. See https://home-assistant.io/docs/mqtt/broker#embedded-broker for details

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5993

Example entry for configuration.yaml (if applicable):

mqtt:
  password: YOUR_MQTT_PASSWORD

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@awarecan awarecan requested a review from a team as a code owner August 11, 2018 13:19
@ghost ghost assigned awarecan Aug 11, 2018
@ghost ghost added the in progress label Aug 11, 2018
@awarecan awarecan changed the title MQTT embedded broker has to set its own password. MQTT embedded broker has to set its own password Aug 11, 2018
@balloob balloob merged commit 45f12dd into home-assistant:dev Aug 13, 2018
@ghost ghost removed the in progress label Aug 13, 2018
@balloob
Copy link
Member

balloob commented Aug 13, 2018

I didn't see this one yet and created an auth plugin for hbmqtt to make it work with new auth system 👍 will rebase on this PR.

@vad
Copy link

vad commented Aug 17, 2018

Couldn't find how to migrate using https://www.home-assistant.io/docs/mqtt/broker#embedded-broker , found it here. It would be nice to explain it there

@ptc
Copy link
Contributor

ptc commented Aug 18, 2018

So how do I migrate?

@balloob
Copy link
Member

balloob commented Aug 19, 2018

Don't use old PRs to ask for help/report issues. We have forums and chat for that.

From the docs: https://www.home-assistant.io/docs/mqtt/broker#embedded-broker

mqtt:
  password: YOUR_MQTT_PASSWORD

@home-assistant home-assistant locked as resolved and limited conversation to collaborators Aug 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants