Fixed status reporting and expose new modes (arm night, arm max) #16051

abarbaccia · 2018-08-18T20:54:43Z

Description:

I reworked the status reporting on envisalink boards. This should now correctly report for ARMING and differentiate between ARM HOME and ARM NIGHT.

I also started to add support for ARM MAX which is when you arm away and have no exit delay (some systems call this "vacation mode"). The capability already seems to be present in pyenvisalink but not sure if it's exposed in the home assistant components yet. For now, it's only status, so it's reported correctly if you arm that mode from the envisalink app.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for `configuration.yaml` (if applicable):

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

Add support for Arm Max (arm away + no entry delay)

homeassistant · 2018-08-18T20:54:44Z

Hi @abarbaccia,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

houndci-bot · 2018-08-18T20:54:54Z

homeassistant/components/alarm_control_panel/envisalink.py

+            state = STATE_ALARM_ARMED_MAX
+        elif self._info['status']['armed_stay'] and not self._info['status']['armed_zero_entry_delay']:
+            state = STATE_ALARM_ARMED_HOME
+        elif self._info['status']['armed_stay'] and self._info['status']['armed_zero_entry_delay']:


line too long (99 > 79 characters)

houndci-bot · 2018-08-18T20:54:54Z

homeassistant/components/alarm_control_panel/envisalink.py

+            state = STATE_ALARM_ARMED_AWAY
+        elif self._info['status']['armed_away'] and self._info['status']['armed_zero_entry_delay']:
+            state = STATE_ALARM_ARMED_MAX
+        elif self._info['status']['armed_stay'] and not self._info['status']['armed_zero_entry_delay']:


line too long (103 > 79 characters)

houndci-bot · 2018-08-18T20:54:54Z

homeassistant/components/alarm_control_panel/envisalink.py

-        elif self._info['status']['alpha']:
+        elif self._info['status']['armed_away'] and not self._info['status']['armed_zero_entry_delay']:
+            state = STATE_ALARM_ARMED_AWAY
+        elif self._info['status']['armed_away'] and self._info['status']['armed_zero_entry_delay']:


line too long (99 > 79 characters)

houndci-bot · 2018-08-18T20:54:54Z

homeassistant/components/alarm_control_panel/envisalink.py

        elif self._info['status']['entry_delay']:
            state = STATE_ALARM_PENDING
-        elif self._info['status']['alpha']:
+        elif self._info['status']['armed_away'] and not self._info['status']['armed_zero_entry_delay']:


line too long (103 > 79 characters)

houndci-bot · 2018-08-18T20:54:54Z

homeassistant/components/alarm_control_panel/envisalink.py

-    STATE_ALARM_ARMED_AWAY, STATE_ALARM_ARMED_HOME, STATE_ALARM_DISARMED,
-    STATE_UNKNOWN, STATE_ALARM_TRIGGERED, STATE_ALARM_PENDING, ATTR_ENTITY_ID)
+    STATE_ALARM_ARMED_AWAY, STATE_ALARM_ARMED_HOME, STATE_ALARM_ARMED_NIGHT, STATE_ALARM_ARMED_MAX, STATE_ALARM_DISARMED,
+    STATE_UNKNOWN, STATE_ALARM_ARMING, STATE_ALARM_TRIGGERED, STATE_ALARM_PENDING, ATTR_ENTITY_ID)


line too long (98 > 79 characters)

houndci-bot · 2018-08-18T20:54:54Z

homeassistant/components/alarm_control_panel/envisalink.py

@@ -17,8 +17,8 @@
    DATA_EVL, EnvisalinkDevice, PARTITION_SCHEMA, CONF_CODE, CONF_PANIC,
    CONF_PARTITIONNAME, SIGNAL_KEYPAD_UPDATE, SIGNAL_PARTITION_UPDATE)
 from homeassistant.const import (
-    STATE_ALARM_ARMED_AWAY, STATE_ALARM_ARMED_HOME, STATE_ALARM_DISARMED,
-    STATE_UNKNOWN, STATE_ALARM_TRIGGERED, STATE_ALARM_PENDING, ATTR_ENTITY_ID)
+    STATE_ALARM_ARMED_AWAY, STATE_ALARM_ARMED_HOME, STATE_ALARM_ARMED_NIGHT, STATE_ALARM_ARMED_MAX, STATE_ALARM_DISARMED,


line too long (121 > 79 characters)

abarbaccia

I tested these on my envisalink hardware and it works as expected.

bachya · 2018-08-21T02:40:37Z

@abarbaccia You still need to fix your linting issues (both those provided by Hound and those provided by Travis).

Add functionality to call Arm Max service

houndci-bot · 2018-08-21T03:11:05Z

homeassistant/components/alarm_control_panel/envisalink.py

+            state = STATE_ALARM_ARMED_HOME
+        elif self._info['status']['armed_stay'] and 
+            self._info['status']['armed_zero_entry_delay']:
+            state = STATE_ALARM_ARMED_NIGHT


expected an indented block

houndci-bot · 2018-08-21T03:11:05Z

homeassistant/components/alarm_control_panel/envisalink.py

+            not self._info['status']['armed_zero_entry_delay']:
+            state = STATE_ALARM_ARMED_HOME
+        elif self._info['status']['armed_stay'] and 
+            self._info['status']['armed_zero_entry_delay']:


unexpected indentation

houndci-bot · 2018-08-21T03:11:06Z

homeassistant/components/alarm_control_panel/envisalink.py

+        elif self._info['status']['armed_stay'] and 
+            not self._info['status']['armed_zero_entry_delay']:
+            state = STATE_ALARM_ARMED_HOME
+        elif self._info['status']['armed_stay'] and 


trailing whitespace

houndci-bot · 2018-08-21T03:11:06Z

homeassistant/components/alarm_control_panel/envisalink.py

+            state = STATE_ALARM_ARMED_MAX
+        elif self._info['status']['armed_stay'] and 
+            not self._info['status']['armed_zero_entry_delay']:
+            state = STATE_ALARM_ARMED_HOME


expected an indented block

houndci-bot · 2018-08-21T03:11:06Z

homeassistant/components/alarm_control_panel/envisalink.py

+            self._info['status']['armed_zero_entry_delay']:
+            state = STATE_ALARM_ARMED_MAX
+        elif self._info['status']['armed_stay'] and 
+            not self._info['status']['armed_zero_entry_delay']:


unexpected indentation

houndci-bot · 2018-08-21T03:11:06Z

homeassistant/components/alarm_control_panel/envisalink.py

        elif self._info['status']['entry_delay']:
            state = STATE_ALARM_PENDING
-        elif self._info['status']['alpha']:
+        elif self._info['status']['armed_away'] and 


trailing whitespace
SyntaxError: invalid syntax

houndci-bot · 2018-08-21T03:11:07Z

homeassistant/components/alarm_control_panel/envisalink.py

-    STATE_UNKNOWN, STATE_ALARM_TRIGGERED, STATE_ALARM_PENDING, ATTR_ENTITY_ID)
+    STATE_ALARM_ARMED_AWAY, STATE_ALARM_ARMED_HOME, STATE_ALARM_ARMED_NIGHT,  
+    STATE_ALARM_ARMED_MAX, STATE_ALARM_DISARMED, STATE_UNKNOWN, 
+    STATE_ALARM_ARMING, STATE_ALARM_TRIGGERED, STATE_ALARM_PENDING, 


trailing whitespace

houndci-bot · 2018-08-21T03:11:07Z

homeassistant/components/alarm_control_panel/envisalink.py

-    STATE_ALARM_ARMED_AWAY, STATE_ALARM_ARMED_HOME, STATE_ALARM_DISARMED,
-    STATE_UNKNOWN, STATE_ALARM_TRIGGERED, STATE_ALARM_PENDING, ATTR_ENTITY_ID)
+    STATE_ALARM_ARMED_AWAY, STATE_ALARM_ARMED_HOME, STATE_ALARM_ARMED_NIGHT,  
+    STATE_ALARM_ARMED_MAX, STATE_ALARM_DISARMED, STATE_UNKNOWN, 


trailing whitespace

houndci-bot · 2018-08-21T03:11:07Z

homeassistant/components/alarm_control_panel/envisalink.py

@@ -17,8 +17,10 @@
    DATA_EVL, EnvisalinkDevice, PARTITION_SCHEMA, CONF_CODE, CONF_PANIC,
    CONF_PARTITIONNAME, SIGNAL_KEYPAD_UPDATE, SIGNAL_PARTITION_UPDATE)
 from homeassistant.const import (
-    STATE_ALARM_ARMED_AWAY, STATE_ALARM_ARMED_HOME, STATE_ALARM_DISARMED,
-    STATE_UNKNOWN, STATE_ALARM_TRIGGERED, STATE_ALARM_PENDING, ATTR_ENTITY_ID)
+    STATE_ALARM_ARMED_AWAY, STATE_ALARM_ARMED_HOME, STATE_ALARM_ARMED_NIGHT,  


trailing whitespace

houndci-bot · 2018-08-21T03:11:07Z

homeassistant/components/alarm_control_panel/__init__.py

@@ -13,7 +13,8 @@
 from homeassistant.const import (
    ATTR_CODE, ATTR_CODE_FORMAT, ATTR_ENTITY_ID, SERVICE_ALARM_TRIGGER,
    SERVICE_ALARM_DISARM, SERVICE_ALARM_ARM_HOME, SERVICE_ALARM_ARM_AWAY,
-    SERVICE_ALARM_ARM_NIGHT, SERVICE_ALARM_ARM_CUSTOM_BYPASS)
+    SERVICE_ALARM_ARM_NIGHT, SERVICE_ALARM_ARM_MAX, 


trailing whitespace

homeassistant/components/alarm_control_panel/__init__.py

balloob · 2018-11-06T13:09:30Z

This PR seems to have gone stale. Closing it.

Cinntax and others added 2 commits August 12, 2018 23:43

Added the ability to call arm_night

949e531

Fixed status reporting

b6b14a7

Add support for Arm Max (arm away + no entry delay)

abarbaccia requested a review from a team as a code owner August 18, 2018 20:54

homeassistant added cla-needed integration: envisalink core platform: alarm_control_panel.envisalink small-pr PRs with less than 30 lines. labels Aug 18, 2018

ghost added the in progress label Aug 18, 2018

houndci-bot reviewed Aug 18, 2018

View reviewed changes

homeassistant added cla-signed and removed cla-needed labels Aug 18, 2018

abarbaccia commented Aug 21, 2018

View reviewed changes

Fixed linting

c975eb9

Add functionality to call Arm Max service

homeassistant added the cla-signed label Aug 21, 2018

houndci-bot reviewed Aug 21, 2018

View reviewed changes

abarbaccia changed the title ~~Fixed status~~ Fixed status reporting and expose new arm services (arm night, arm max) Aug 21, 2018

abarbaccia changed the title ~~Fixed status reporting and expose new arm services (arm night, arm max)~~ Fixed status reporting and expose new modes (arm night, arm max) Aug 21, 2018

Fixed linting as requested by hound

32c861b

homeassistant added the cla-signed label Aug 21, 2018

MartinHjelmare requested changes Aug 21, 2018

View reviewed changes

homeassistant/components/alarm_control_panel/__init__.py Show resolved Hide resolved

abarbaccia mentioned this pull request Aug 21, 2018

Add Arm Max service to alarm_control_panel home-assistant/architecture#60

Closed

balloob closed this Nov 6, 2018

ghost removed the in progress label Nov 6, 2018

home-assistant locked and limited conversation to collaborators Feb 5, 2019

ghost removed the platform: alarm_control_panel.envisalink label Mar 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed status reporting and expose new modes (arm night, arm max) #16051

Fixed status reporting and expose new modes (arm night, arm max) #16051

abarbaccia commented Aug 18, 2018 •

edited

homeassistant commented Aug 18, 2018

houndci-bot Aug 18, 2018

houndci-bot Aug 18, 2018

houndci-bot Aug 18, 2018

houndci-bot Aug 18, 2018

houndci-bot Aug 18, 2018

houndci-bot Aug 18, 2018

abarbaccia left a comment

bachya commented Aug 21, 2018

houndci-bot Aug 21, 2018

houndci-bot Aug 21, 2018

houndci-bot Aug 21, 2018

houndci-bot Aug 21, 2018

houndci-bot Aug 21, 2018

houndci-bot Aug 21, 2018

houndci-bot Aug 21, 2018

houndci-bot Aug 21, 2018

houndci-bot Aug 21, 2018

houndci-bot Aug 21, 2018

balloob commented Nov 6, 2018

Fixed status reporting and expose new modes (arm night, arm max) #16051

Fixed status reporting and expose new modes (arm night, arm max) #16051

Conversation

abarbaccia commented Aug 18, 2018 • edited

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

homeassistant commented Aug 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

abarbaccia left a comment

Choose a reason for hiding this comment

bachya commented Aug 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

balloob commented Nov 6, 2018

abarbaccia commented Aug 18, 2018 •

edited

Example entry for `configuration.yaml` (if applicable):