-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoneminder SSL fix #16157
Merged
Merged
Zoneminder SSL fix #16157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a verify_ssl parameter for zoneminder
homeassistant
added
integration: zoneminder
small-pr
PRs with less than 30 lines.
cla-needed
labels
Aug 23, 2018
ghost
added
the
in progress
label
Aug 23, 2018
ghost
assigned fabaff
Aug 24, 2018
houndci-bot
reviewed
Aug 24, 2018
_LOGGER.exception('JSON decode exception caught while attempting to ' | ||
'decode "%s"', req.text) | ||
_LOGGER.exception( | ||
"JSON decode exception caught while attempting to decode: %s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing whitespace
fabaff
approved these changes
Aug 24, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🐦
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added option to disable ssl verification checks for the zoneminder module
This is a re-try of #14869 which erroneously contained other commits due to my complete lack of git skills (apologies for that).
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#5507
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: