Added 'nomapnt', 'outcurnt', 'loadapnt' fields #16176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @MarcSN311, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
homeassistant
added
merging-to-master
ghost
added
the
houndci-bot
reviewed
Aug 24, 2018
| @@ -49,6 +49,7 @@ | |||
| 'linefreq': ['Line Frequency', 'Hz', 'mdi:information-outline'], | |||
| 'linev': ['Input Voltage', 'V', 'mdi:flash'], | |||
| 'loadpct': ['Load', '%', 'mdi:gauge'], | |||
| 'loadapnt' : ['Load Apparent Power', '%', 'mdi:gauge'], | |||
|
Please rebase and change target branch to dev. |
fabaff
added
docs-missing
and removed
merging-to-master
Also added Ampere and Volt-Ampere to INFERRED_UNITS
|
I rebased. What does the "docs-missing" label mean? |
|
There were instructions about that in the PR template. |
2 tasks
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Added 'nomapnt', 'outcurnt', 'loadapnt' fields Also added Ampere and Volt-Ampere to INFERRED_UNITS * Fix lint issue
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added 'nomapnt', 'outcurnt', 'loadapnt' fields and the correspoding Units Ampere and Volt-Ampere to INFERRED_UNITS.