Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'moon_phase' to Dark Sky sensor #16179

Merged
merged 1 commit into from
Aug 24, 2018
Merged

Add 'moon_phase' to Dark Sky sensor #16179

merged 1 commit into from
Aug 24, 2018

Conversation

fabaff
Copy link
Member

@fabaff fabaff commented Aug 24, 2018

Description:

Add 'moon_phase' to Dark Sky sensor.

Related issue (if applicable): fixes 65461

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6076

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: darksky
    api_key: !secret darksky_api
    monitored_conditions:
      - moon_phase

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

@ghost ghost assigned fabaff Aug 24, 2018
@ghost ghost added the in progress label Aug 24, 2018
@bachya bachya merged commit 69cea60 into dev Aug 24, 2018
@ghost ghost removed the in progress label Aug 24, 2018
@fabaff fabaff deleted the darksky-moon branch August 25, 2018 09:37
@balloob balloob mentioned this pull request Sep 17, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants