Add Volkszaehler sensor #16188
Merged
Add Volkszaehler sensor #16188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
2 tasks
| host = config.get(CONF_HOST) | ||
| name = config.get(CONF_NAME) | ||
| port = config.get(CONF_PORT) | ||
| uuid = config.get(CONF_UUID) |
There was a problem hiding this comment.
Use dict[key] for required config keys.
| self._name = name | ||
| self.type = sensor_type | ||
| self._state = None | ||
| self._unit_of_measurement = SENSOR_TYPES[sensor_type][1] |
There was a problem hiding this comment.
Do we need this attribute? Icon doesn't use a dedicated attribute.
| await self.vz_api.async_update() | ||
|
|
||
| if self.vz_api.api.data is not None: | ||
| if self.type == 'average': |
There was a problem hiding this comment.
We could use getattr:
self._state = round(getattr(self.vz_api.api, self.type), 2)
mbennett
pushed a commit
to mbennett/home-assistant
that referenced
this pull request
Aug 27, 2018
* Add Volkszaehler sensor * Update icons * Improve code
girlpunk
pushed a commit
to girlpunk/home-assistant
that referenced
this pull request
Sep 4, 2018
* Add Volkszaehler sensor * Update icons * Improve code
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add support for consuming values exposed by the Volkszähler API.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6081
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.