Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log transmitted as well as received MQTT messages #16195

Merged
merged 1 commit into from
Aug 26, 2018

Conversation

smurfix
Copy link
Contributor

@smurfix smurfix commented Aug 25, 2018

Description:

Currently the MQTT plug only logs incoming messages when debugging is on. However, transmitted messages are equally important. So log them too.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@smurfix smurfix requested a review from a team as a code owner August 25, 2018 20:12
@ghost ghost added the in progress label Aug 25, 2018
@fabaff fabaff changed the title MQTT: Log transmitted as well as received messages Log transmitted as well as received MQTT messages Aug 26, 2018
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit a1ce14e into home-assistant:dev Aug 26, 2018
@ghost ghost removed the in progress label Aug 26, 2018
@smurfix smurfix deleted the p1 branch August 26, 2018 17:09
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@balloob balloob mentioned this pull request Sep 17, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants