-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add device info to Chromecast #16261
Conversation
|
||
return { | ||
'name': cast_info.friendly_name, | ||
'identifiers': [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Identifiers should be set with tuples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tuples with 1 entry are very error prone, as the comma is what makes it the tuple. We can pass in list because DeviceEntry
will convert it to a set anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, then perhaps I should update deconz to do the same?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made them sets. You're right that it's better to stay in line with how they will end up on the device.
Description:
Add device info to Chromecast.
Checklist:
tox
. Your PR cannot be merged unless tests pass