-
-
Notifications
You must be signed in to change notification settings - Fork 28.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OpenTherm Gateway climate platform #16299
Conversation
Overall cleanup and polishing
Thank you for the very thorough review. Looks like there is still quite some work to do, but that was expected since it's my first real contribution to Home Assistant. I will address all concerns over the next few days. |
Changed wording from "component" to more appropriate terms where necessary Fixed small mistakes that snuck in during testing and/or due to my own ignorance ;)
Updated dependency pyotgw to latest version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't polling be set to False for this entity?
I've been looking for a way to do this, but could not find it in the dev docs before. Seems I missed the "Entities Introduction" part and relied too much on examples from other platforms. |
Improve update flow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Two small comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Description:
Add support for the OpenTherm Gateway.
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6118
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable (example).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.