Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenTherm Gateway climate platform #16299

Merged
merged 12 commits into from
Sep 7, 2018

Conversation

mvn23
Copy link
Contributor

@mvn23 mvn23 commented Aug 30, 2018

Description:

Add support for the OpenTherm Gateway.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6118

Example entry for configuration.yaml (if applicable):

climate:
  - platform: opentherm_gw
    device: /dev/ttyUSB0

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

homeassistant/components/climate/opentherm_gw.py Outdated Show resolved Hide resolved
homeassistant/components/climate/opentherm_gw.py Outdated Show resolved Hide resolved
homeassistant/components/climate/opentherm_gw.py Outdated Show resolved Hide resolved
homeassistant/components/climate/opentherm_gw.py Outdated Show resolved Hide resolved
homeassistant/components/climate/opentherm_gw.py Outdated Show resolved Hide resolved
homeassistant/components/climate/opentherm_gw.py Outdated Show resolved Hide resolved
homeassistant/components/climate/opentherm_gw.py Outdated Show resolved Hide resolved
homeassistant/components/climate/opentherm_gw.py Outdated Show resolved Hide resolved
homeassistant/components/climate/opentherm_gw.py Outdated Show resolved Hide resolved
homeassistant/components/climate/opentherm_gw.py Outdated Show resolved Hide resolved
@mvn23 mvn23 changed the title Add OpenTherm Gateway climate component. [WIP] Add OpenTherm Gateway climate component. Sep 4, 2018
@mvn23
Copy link
Contributor Author

mvn23 commented Sep 4, 2018

Thank you for the very thorough review. Looks like there is still quite some work to do, but that was expected since it's my first real contribution to Home Assistant. I will address all concerns over the next few days.

@mvn23 mvn23 changed the title [WIP] Add OpenTherm Gateway climate component. [WIP] Add OpenTherm Gateway climate platform. Sep 5, 2018
Changed wording from "component" to more appropriate terms where necessary
Fixed small mistakes that snuck in during testing and/or due to my own ignorance ;)
@mvn23 mvn23 changed the title [WIP] Add OpenTherm Gateway climate platform. Add OpenTherm Gateway climate platform Sep 5, 2018
@mvn23 mvn23 closed this Sep 5, 2018
@ghost ghost removed the in progress label Sep 5, 2018
@mvn23 mvn23 reopened this Sep 5, 2018
@ghost ghost added the in progress label Sep 5, 2018
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't polling be set to False for this entity?

@mvn23
Copy link
Contributor Author

mvn23 commented Sep 5, 2018

Shouldn't polling be set to False for this entity?

I've been looking for a way to do this, but could not find it in the dev docs before. Seems I missed the "Entities Introduction" part and relied too much on examples from other platforms.
I will have a look and prepare another commit tonight or tomorrow.
Thanks for the feedback!

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Two small comments.

homeassistant/components/climate/opentherm_gw.py Outdated Show resolved Hide resolved
homeassistant/components/climate/opentherm_gw.py Outdated Show resolved Hide resolved
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@MartinHjelmare MartinHjelmare merged commit 7ad094b into home-assistant:dev Sep 7, 2018
@ghost ghost removed the in progress label Sep 7, 2018
@mvn23 mvn23 deleted the opentherm-gateway branch September 8, 2018 19:31
@balloob balloob mentioned this pull request Sep 17, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants