Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Sonos Beam HDMI input #16340

Merged
merged 1 commit into from
Sep 1, 2018
Merged

Conversation

phil65
Copy link
Contributor

@phil65 phil65 commented Aug 31, 2018

Description:

Add Sonos Beam HDMI support

Related issue (if applicable):

Pull request in home-assistant.github.io with documentation (if applicable):

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@phil65 phil65 requested a review from amelchio as a code owner August 31, 2018 23:25
@homeassistant
Copy link
Contributor

Hi @phil65,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Contributor

@amelchio amelchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, and welcome!

This addition looks fine.

However, please fill out the template text that you deleted when you submitted the PR. Most of it is not relevant for this PR and you can leave it unchecked but the part about the code being tested is always interesting.

@fabaff fabaff changed the title [sonos] - support Sonos Beam HDMI input Support Sonos Beam HDMI input Sep 1, 2018
@phil65
Copy link
Contributor Author

phil65 commented Sep 1, 2018

done.

Copy link
Contributor

@amelchio amelchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@amelchio amelchio merged commit 901cfef into home-assistant:dev Sep 1, 2018
@ghost ghost removed the in progress label Sep 1, 2018
@balloob balloob mentioned this pull request Sep 17, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants