Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add topic checking config to default config of embeded mqtt server #16375

Merged
merged 1 commit into from
Sep 2, 2018

Conversation

awarecan
Copy link
Contributor

@awarecan awarecan commented Sep 2, 2018

Description:

In hbmqtt 0.9.3, a topic checking feature added' which required default config have to include topic-check section.

See #16356

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@awarecan awarecan requested a review from a team as a code owner September 2, 2018 17:46
@ghost ghost assigned awarecan Sep 2, 2018
@ghost ghost added the in progress label Sep 2, 2018
@awarecan
Copy link
Contributor Author

awarecan commented Sep 2, 2018

@fabaff could you help to validate this fix?

Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 🐦

@fabaff fabaff merged commit 4685a2c into dev Sep 2, 2018
@ghost ghost removed the in progress label Sep 2, 2018
@fabaff fabaff deleted the awarecan-mqtt-drfualt-check-topic branch September 2, 2018 20:17
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@balloob balloob mentioned this pull request Sep 17, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants