Jewish calendar sensor #16393

tsvi · 2018-09-03T15:36:00Z

Description:

This adds a Jewish calendar sensor to home assistant.
By default it displays the current Hebrew calendar date in English characters.

G-d willing, I'll be adding more sensors in the future and cleanup the API for hdate so the interface between Hass and hdate can be done in a cleaner fashion.
At the moment I implemented the most interesting sensors.
Also on the TODO list is changing the Hebrew date at sunset as is customary in Jewish practice.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6265

Example entry for `configuration.yaml` (if applicable):

sensor:
  - platform: jewish_calendar
    language: <hebrew or english>
    latitude: <coordinates for given sensor>
    longitude: <coordinates for given sensor>
    disapora: <True or False>
    sensors:
      - date
      - weekly_portion
      - holiday_name
      - holyness
      - first_light
      - gra_end_shma
      - mga_end_shma
      - plag_mincha
      - first_stars

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

houndci-bot · 2018-09-03T16:04:25Z

homeassistant/components/sensor/jewish_calendar.py

+
+from homeassistant.components.sensor import PLATFORM_SCHEMA
+
+import homeassistant.helpers.config_validation as cv


'homeassistant.helpers.config_validation as cv' imported but unused

houndci-bot · 2018-09-05T07:12:15Z

homeassistant/components/sensor/jewish_calendar.py

+https://home-assistant.io/components/sensor.jewish_calendar/
+"""
+import logging
+from datetime import date as dt


'datetime.date as dt' imported but unused

Will need to update hdate API and version before continuing.

frenck · 2018-09-09T14:51:43Z

Could not find a matching PR in the documentation. Added the docs-missing label.

balloob · 2018-09-13T07:49:50Z

homeassistant/components/sensor/jewish_calendar.py

+CONF_SENSORS = 'sensors'
+
+DEFAULT_NAME = 'Jewish Calendar'
+DEFAULT_LATITUDE = 31.778


We should default to the users location

Oh, you already do that. In that case, please remove these as they serve no purpose.

balloob · 2018-09-13T07:51:40Z

homeassistant/components/sensor/jewish_calendar.py

+
+    def __init__(self, name, language, sensor_type,
+                 latitude=DEFAULT_LATITUDE, longitude=DEFAULT_LONGITUDE,
+                 diaspora=False):


Should be no defaults here, defaults should be set in voluptuous schema.

balloob · 2018-09-13T07:52:32Z

homeassistant/components/sensor/jewish_calendar.py

+        """Update the state of the sensor."""
+        import hdate
+
+        self._date = dt_util.now().date()


There is no reason to store this as an instance variable, it's only used in this method.

fabaff

Thanks 🐦

tes5884 · 2018-09-28T15:45:09Z

THANK YOU!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!

dshanske · 2018-09-30T20:58:26Z

Why is it disapora and not diaspora?

tsvi added 8 commits September 3, 2018 09:51

Initial commit for jewish calendar sensor

0ef3c86

Make check for logging errors into it's own function

d36b2b5

Can't use f-strings as we need to support python3.5

eaca93d

Implement basic functionality: printing of date

3336be3

Update requirements_all.txt

d6bfff3

Allow user to specify date for sensor

55a14a4

Add hdate to test requirements

fa69683

Update to match pull request

d9457ba

tsvi requested a review from a team as a code owner September 3, 2018 15:36

homeassistant added cla-signed core new-platform platform: sensor.jewish_calendar labels Sep 3, 2018

ghost added the in progress label Sep 3, 2018

homeassistant added the cla-signed label Sep 3, 2018

tsvi added 2 commits September 3, 2018 18:58

Support date output in hebrew

f583437

Limit languages to english and hebrew

9d352df

houndci-bot reviewed Sep 3, 2018

View reviewed changes

tsvi added 4 commits September 3, 2018 19:09

Add name back to sensor

b29a267

Change icon to be calendar-today

25a469a

Add multiple sensors

afababc

Fix tests

47a6883

houndci-bot reviewed Sep 5, 2018

View reviewed changes

tsvi added 7 commits September 5, 2018 10:14

Make Hound happy, remove unused imported class

263d0cb

hdate expects datetime.date not datetime.datetime

065cf9e

Return sensor name

24ad630

Times should be returned as time object, not datetime

39636fb

Add myself to codeowners for jewish calendar component

b2bc90c

Return actual reading, not index

5e09adf

Add more tests. Currently failing.

5242b6c

Will need to update hdate API and version before continuing.

tsvi added 3 commits September 7, 2018 01:20

Fix weekly portion test

e3cdfcd

Make all tests pass

e5c2bf7

Make travis happy and add a test so it doesnt happen again

ff8f827

tsvi changed the title ~~WIP: Jewish calendar sensor~~ Jewish calendar sensor Sep 6, 2018

frenck added the docs-missing label Sep 9, 2018

tsvi mentioned this pull request Sep 12, 2018

Jewish calendar component documentation home-assistant/home-assistant.io#6265

Merged

2 tasks

balloob reviewed Sep 13, 2018

View reviewed changes

tsvi added 2 commits September 16, 2018 11:45

Remove defaults in __init__ method

b3bb2ff

Change sensor state variable to local variable in update() method

7fc876e

homeassistant added the cla-signed label Sep 16, 2018

Minor changes

b8bf932

ghost assigned fabaff Sep 17, 2018

fabaff approved these changes Sep 17, 2018

View reviewed changes

fabaff merged commit 25712f1 into home-assistant:dev Sep 17, 2018

ghost removed the in progress label Sep 17, 2018

balloob mentioned this pull request Sep 28, 2018

0.79.0 #16940

Merged

home-assistant locked as resolved and limited conversation to collaborators Sep 30, 2018

tsvi deleted the jcal branch October 4, 2018 10:42

tsvi restored the jcal branch October 4, 2018 10:43

tsvi deleted the jcal branch October 4, 2018 10:43

ghost added integration: jewish_calendar and removed platform: sensor.jewish_calendar labels Mar 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Jewish calendar sensor #16393

Jewish calendar sensor #16393

tsvi commented Sep 3, 2018 •

edited

houndci-bot Sep 3, 2018

houndci-bot Sep 5, 2018

frenck commented Sep 9, 2018

balloob Sep 13, 2018

balloob Sep 13, 2018

balloob Sep 13, 2018

balloob Sep 13, 2018

fabaff left a comment

tes5884 commented Sep 28, 2018

dshanske commented Sep 30, 2018


		from homeassistant.components.sensor import PLATFORM_SCHEMA

		import homeassistant.helpers.config_validation as cv

Jewish calendar sensor #16393

Jewish calendar sensor #16393

Conversation

tsvi commented Sep 3, 2018 • edited

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

houndci-bot Sep 3, 2018

Choose a reason for hiding this comment

houndci-bot Sep 5, 2018

Choose a reason for hiding this comment

frenck commented Sep 9, 2018

balloob Sep 13, 2018

Choose a reason for hiding this comment

balloob Sep 13, 2018

Choose a reason for hiding this comment

balloob Sep 13, 2018

Choose a reason for hiding this comment

balloob Sep 13, 2018

Choose a reason for hiding this comment

fabaff left a comment

Choose a reason for hiding this comment

tes5884 commented Sep 28, 2018

dshanske commented Sep 30, 2018

tsvi commented Sep 3, 2018 •

edited

Example entry for `configuration.yaml` (if applicable):