switchbot #16396
Merged
switchbot #16396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
2 tasks
| self._mac = mac | ||
| self._device = None | ||
|
|
||
| def _sendpacket(self, key, retry=2) -> bool: |
There was a problem hiding this comment.
This belongs in a standalone library.
There was a problem hiding this comment.
Ok, I thought it might be ok since it so few lines.
But I will make a standalone library.
houndci-bot
reviewed
Sep 5, 2018
| For more details about this platform, please refer to the documentation at | ||
| https://home-assistant.io/components/switch.switchbot | ||
| """ | ||
| import binascii |
| }) | ||
|
|
||
|
|
||
| def setup_platform(hass, config, add_devices, discovery_info=None): |
There was a problem hiding this comment.
Rename add_devices to add_entities.
| def setup_platform(hass, config, add_devices, discovery_info=None): | ||
| """Perform the setup for Switchbot devices.""" | ||
| name = config.get(CONF_NAME) | ||
| mac_addr = config.get(CONF_MAC) |
There was a problem hiding this comment.
Use dict[key] for required config keys.
MartinHjelmare
approved these changes
Sep 6, 2018
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds support for https://www.switch-bot.com/
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6186
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable ([example][ex-requir]).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.