Add Support for Xiaomi Vibration Sensor #16422

dlashua · 2018-09-04T17:48:11Z

Description:

Adds support for Xiaomi Vibration Sensor

Example entry for `configuration.yaml` (if applicable):

n/a auto discovered

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:

New dependencies have been added to the REQUIREMENTS variable (example).
New dependencies are only imported inside functions that use them (example).
New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
New files were added to .coveragerc.

If the code does not interact with devices:

Tests have been added to verify that the new code works.

allow UNIT and ID to contain alphanumeric characters

…into dev

homeassistant · 2018-09-04T17:48:13Z

Hi @dlashua,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

houndci-bot · 2018-09-04T17:48:22Z

homeassistant/components/sensor/xiaomi_aqara.py

@@ -84,6 +94,9 @@ def parse_data(self, data, raw_data):
        value = data.get(self._data_key)
        if value is None:
            return False
+        if self._data_key in ['coordination','status']:


missing whitespace after ','

houndci-bot · 2018-09-04T17:48:23Z

homeassistant/components/sensor/xiaomi_aqara.py

+                devices.append(XiaomiSensor(device, 'Tilt Angle',
+                                            'final_tilt_angle',gateway))
+                devices.append(XiaomiSensor(device, 'Coordination',
+                                            'coordination', gateway))                


trailing whitespace

houndci-bot · 2018-09-04T17:48:23Z

homeassistant/components/sensor/xiaomi_aqara.py

+                devices.append(XiaomiSensor(device, 'Bed Activity',
+                                            'bed_activity', gateway))
+                devices.append(XiaomiSensor(device, 'Tilt Angle',
+                                            'final_tilt_angle',gateway))


missing whitespace after ','

homeassistant · 2018-09-04T17:51:37Z

Hi @dlashua,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant · 2018-09-04T17:52:20Z

Hi @dlashua,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant · 2018-09-04T17:54:56Z

Hi @dlashua,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

dlashua · 2018-09-04T18:53:29Z

Travis CI is failing because of the use of _LOGGER.warn(). This code was not modified by me. It must not have been converted to whatever the new method is.

homeassistant/components/sensor/xiaomi_aqara.py

Danielhiversen · 2018-09-04T19:22:27Z

homeassistant/components/sensor/xiaomi_aqara.py

+                                            'coordination', gateway))
+            else:
+                _LOGGER.warn("Unmapped Device Model ")
+                _LOGGER.warn(device)


homeassistant/components/binary_sensor/xiaomi_aqara.py

dlashua · 2018-09-06T15:36:55Z

Documentation PR has been submitted ( home-assistant/home-assistant.io#6207 ).

Please note, this requires an updated version of PyXiaomiGateway (PR already submitted Danielhiversen/PyXiaomiGateway#89 ). This will likely result in a verison number increase of that library which means the REQUIREMENTS on this component will also need to increment.

…into dev

Danielhiversen

🎉

balloob · 2018-09-25T18:49:26Z

@Danielhiversen can this be merged?

syssi

LGTM. Just the documentation isn't ready.

PaulAnnekov · 2018-10-13T15:00:29Z

@dlashua I often get a WARNING (MainThread) [homeassistant.components.binary_sensor.xiaomi_aqara] Unsupported movement_type detected: None warning, when rotating sensor. I think, that's because status field is not always present, e.g. sometimes I see messages like this: [xiaomi_gateway] MCAST (report) << {'cmd': 'report', 'model': 'vibration', 'sid': '158d0002a239d9', 'short_id': 53265, 'data': '{"coordination":"75,15,-702"}'}.

MartinHjelmare · 2018-10-13T15:47:09Z

@PaulAnnekov please open an issue.

dlashua added 4 commits December 12, 2016 07:21

UNIT and ID type changes

528988a

allow UNIT and ID to contain alphanumeric characters

make unit a positive int

186984c

Merge branch 'dev' of https://github.com/home-assistant/home-assistant …

6acfd50

…into dev

Support Xiaomi Vibration Sensor

3d5690b

dlashua requested review from Danielhiversen and syssi as code owners September 4, 2018 17:48

homeassistant added cla-needed platform: binary_sensor.xiaomi_aqara labels Sep 4, 2018

ghost added the in progress label Sep 4, 2018

houndci-bot reviewed Sep 4, 2018

View reviewed changes

adding whitespace before comma

9e36434

homeassistant added the cla-needed label Sep 4, 2018

adding whitespace before comma

34b8c65

homeassistant added the cla-needed label Sep 4, 2018

remove trailing whitespace

c435400

homeassistant added cla-signed and removed cla-needed labels Sep 4, 2018

dlashua mentioned this pull request Sep 4, 2018

Add support for Xiaomi Vibration sensor Danielhiversen/PyXiaomiGateway#89

Merged

Danielhiversen reviewed Sep 4, 2018

View reviewed changes

homeassistant/components/sensor/xiaomi_aqara.py Outdated Show resolved Hide resolved

Danielhiversen reviewed Sep 4, 2018

View reviewed changes

removed warning for unknown models

34c40eb

homeassistant added the cla-signed label Sep 4, 2018

dlashua added 2 commits September 4, 2018 14:32

readded warning so that only device output is removed

3b00151

readding warning for unmapped device model

ad15cec

line too long for houndci-bot

556bf3f

houndci-bot reviewed Sep 5, 2018

View reviewed changes

homeassistant/components/binary_sensor/xiaomi_aqara.py Outdated Show resolved Hide resolved

clean up trailing whitespace

9842eb2

Danielhiversen reviewed Sep 5, 2018

View reviewed changes

homeassistant/components/binary_sensor/xiaomi_aqara.py Show resolved Hide resolved

making additional changes requested.

9365357

houndci-bot reviewed Sep 5, 2018

View reviewed changes

homeassistant/components/binary_sensor/xiaomi_aqara.py Outdated Show resolved Hide resolved

add more spacing to make houndci-bot happy

e0d02a3

Danielhiversen added the docs-missing label Sep 6, 2018

dlashua mentioned this pull request Sep 6, 2018

Adds documentation for Xiaomi Vibration Sensor home-assistant/home-assistant.io#6207

Closed

2 tasks

dlashua added 2 commits September 6, 2018 11:02

Merge branch 'dev' of https://github.com/home-assistant/home-assistant …

106040b

…into dev

Merge branch 'dev' into xiaomiVibration

f7160b6

homeassistant added the cla-signed label Sep 6, 2018

Danielhiversen approved these changes Sep 13, 2018

View reviewed changes

frenck removed the docs-missing label Sep 21, 2018

syssi approved these changes Sep 26, 2018

View reviewed changes

This was referenced Oct 7, 2018

Unsupported Aqara Vibration Sensor - DJT11LM Danielhiversen/PyXiaomiGateway#98

Closed

Unsupported device, vibration, tilt Danielhiversen/PyXiaomiGateway#102

Closed

Add additional model name

cc71ce1

ghost assigned syssi Oct 8, 2018

syssi mentioned this pull request Oct 8, 2018

Add documentation for Xiaomi Vibration Sensor home-assistant/home-assistant.io#6600

Merged

2 tasks

syssi merged commit 71a0274 into home-assistant:dev Oct 8, 2018

ghost removed the in progress label Oct 8, 2018

home-assistant locked as resolved and limited conversation to collaborators Oct 13, 2018

ghost added integration: xiaomi_aqara and removed platform: binary_sensor.xiaomi_aqara labels Mar 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Support for Xiaomi Vibration Sensor #16422

Add Support for Xiaomi Vibration Sensor #16422

dlashua commented Sep 4, 2018 •

edited by frenck

homeassistant commented Sep 4, 2018

houndci-bot Sep 4, 2018

houndci-bot Sep 4, 2018

houndci-bot Sep 4, 2018

homeassistant commented Sep 4, 2018

homeassistant commented Sep 4, 2018

homeassistant commented Sep 4, 2018

dlashua commented Sep 4, 2018

Danielhiversen Sep 4, 2018 •

edited

dlashua commented Sep 6, 2018

Danielhiversen left a comment

balloob commented Sep 25, 2018

syssi left a comment

PaulAnnekov commented Oct 13, 2018

MartinHjelmare commented Oct 13, 2018

Add Support for Xiaomi Vibration Sensor #16422

Add Support for Xiaomi Vibration Sensor #16422

Conversation

dlashua commented Sep 4, 2018 • edited by frenck

Description:

Example entry for configuration.yaml (if applicable):

Checklist:

homeassistant commented Sep 4, 2018

houndci-bot Sep 4, 2018

Choose a reason for hiding this comment

houndci-bot Sep 4, 2018

Choose a reason for hiding this comment

houndci-bot Sep 4, 2018

Choose a reason for hiding this comment

homeassistant commented Sep 4, 2018

homeassistant commented Sep 4, 2018

homeassistant commented Sep 4, 2018

dlashua commented Sep 4, 2018

Danielhiversen Sep 4, 2018 • edited

Choose a reason for hiding this comment

dlashua commented Sep 6, 2018

Danielhiversen left a comment

Choose a reason for hiding this comment

balloob commented Sep 25, 2018

syssi left a comment

Choose a reason for hiding this comment

PaulAnnekov commented Oct 13, 2018

MartinHjelmare commented Oct 13, 2018

dlashua commented Sep 4, 2018 •

edited by frenck

Example entry for `configuration.yaml` (if applicable):

Danielhiversen Sep 4, 2018 •

edited