Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail fetch auth providers if onboarding required #16454

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Fail fetch auth providers if onboarding required #16454

merged 1 commit into from
Sep 10, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Sep 6, 2018

Description:

Fail when fetching auth providers if onboarding is required. This will allow us to redirect users from the authorize page.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@awarecan
Copy link
Contributor

awarecan commented Sep 7, 2018

That reminds me maybe we should set hass.auth.active always True since we turned on new auth now.

@balloob
Copy link
Member Author

balloob commented Sep 7, 2018

Good point. We can remove the old logic

@balloob balloob added this to the 0.78.0 milestone Sep 10, 2018
@balloob balloob merged commit cfe5db4 into dev Sep 10, 2018
@ghost ghost removed the in progress label Sep 10, 2018
@balloob balloob deleted the onboard-msg branch September 10, 2018 21:51
@balloob balloob mentioned this pull request Sep 17, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants